Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Default stackableVersion to operator version #267

Merged
merged 3 commits into from
Aug 3, 2023
Merged

feat: Default stackableVersion to operator version #267

merged 3 commits into from
Aug 3, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 3, 2023 •
edited by razvan
Loading

Description

Part of stackabletech/issues#404

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@sbernauer sbernauer mentioned this pull request Aug 3, 2023
Closed
@sbernauer sbernauer self-assigned this Aug 3, 2023
@sbernauer sbernauer requested review from razvan and adwk67 August 3, 2023 08:45
@razvan razvan removed the request for review from adwk67 August 3, 2023 09:42
razvan
razvan approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

rust/crd/src/affinity.rs Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
@sbernauer sbernauer added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit cb6ac08 Aug 3, 2023
@bors bors bot deleted the feat/stackable-version branch August 3, 2023 11:42
@sbernauer sbernauer mentioned this pull request Aug 3, 2023
Merged
@lfrancke
Copy link
Member

lfrancke commented Sep 5, 2023

Did this change the CRD? Is this a breaking change?

@maltesander
Copy link
Member

Should not be breaking. You can still set the stackable version, or if left out (new) will default to operator version.

@lfrancke
Copy link
Member

But did it change the CRD?

@lfrancke
Copy link
Member

This needs a release note entry saying that we switched the default PullPolicy

@sbernauer
Copy link
Member Author

Yeah, that sounds like a good idea.
Given that we would need to touch the Changelog in every operator, would it be sufficient to mention the change in the platform release notes?

@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@sbernauer sbernauer

Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @lfrancke @maltesander @razvan